Repository navigation
Conversation
`Game.__repr__` falls back to an identity-based form when the game has an empty title, but the f-string lacked its closing parenthesis, producing `Game(id=...` instead of `Game(id=...)`. Add regression tests for the untitled (strategic and extensive) and titled forms, and a ChangeLog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues closed by this PR
None -- small self-found bug; happy to open an issue first if you'd prefer one on record.
Description of the changes in this PR
Game.__repr__falls back toGame(id=...)when the game has an empty title, but the f-string ingame.pxiwas missing its closing parenthesis, so the output was unbalanced:This PR adds the missing
), adds regression tests for both the untitled (StrategicGameandExtensiveGame) and titled forms of the repr intests/test_game.py, and records the fix in theChangeLogunder the unreleased17.0.0-beta.2entry.How to review this PR
src/pygambit/game.pxi(Game.__repr__).pygambitand runpytest tests/test_game.py -k repr; the twotest_repr_untitled_gamecases fail onmasterand pass with this change. I also ranpytest tests/test_game.py tests/test_io.py build_support/releases/test_extract_changelog.pyand theruff/flake8/cython-lintpre-commit hooks on the touched files.