Skip to content

Correct reference counting in wxGridCellWorker objects #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tturocy merged 1 commit into from
Oct 26, 2026
Merged

Correct reference counting in wxGridCellWorker objects #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/gui/nfgheadergrid.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,6 @@ class RowPlayerTable final : public wxGridTableBase {
explicit RowPlayerTable(TableWidget *p_table)
: m_table(p_table), m_renderer(new RowHeaderCellRenderer(p_table))
{
// Freshly-constructed wxGridCellWorker-derived objects start unreferenced;
// this is our own table's stake, matched by DecRef() in the destructor.
// Each SetRenderer() call below additionally consumes one reference per
// call (that's the ownership contract of that setter), so GetAttr() takes
// a fresh IncRef() immediately before each one -- the instance itself is
// reused across all cells and all calls, which is required: wxGrid
// expects the *same* renderer object identity back on repeated queries
// for a given cell.
m_renderer->IncRef();
}

~RowPlayerTable() override { m_renderer->DecRef(); }
Expand Down Expand Up @@ -638,7 +629,6 @@ class ColPlayerTable final : public wxGridTableBase {
explicit ColPlayerTable(TableWidget *p_table)
: m_table(p_table), m_renderer(new ColHeaderCellRenderer(p_table))
{
m_renderer->IncRef();
}

~ColPlayerTable() override { m_renderer->DecRef(); }
Expand Down
2 changes: 0 additions & 2 deletions src/gui/nfgpayoffgrid.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ class PayoffTable final : public wxGridTableBase {
: m_table(p_table), m_renderer(new PayoffCellRenderer(p_table)),
m_editor(new RationalCellEditor())
{
m_renderer->IncRef();
m_editor->IncRef();
}

~PayoffTable() override
Expand Down
Loading