Repository navigation
Correct --accuracy help text in randomstart and bimatrix CLIs - #25
Merged
Merged
Conversation
Coordinates are rounded to multiples of 1/x that sum to 1, which is not always the nearest multiple (see roundArray). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Both documentation-only changes accurately describe the existing rounding behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Corrects CLI help text to accurately describe probability-coordinate rounding.
Changes:
- Clarifies
--accuracybehavior in both affected commands. - Aligns help text with
roundArraybehavior.
| File | Description |
|---|---|
src/lemke/randomstart.py |
Corrects randomstart --accuracy help text. |
src/lemke/bimatrix.py |
Corrects trace random --accuracy help text. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20. The
--accuracyhelp text ofrandomstartandbimatrix trace randomsaid each coordinate is rounded to the nearest multiple of 1/x. As now documented inroundArray, coordinates are rounded to multiples of 1/x that sum to 1, so an entry is not always rounded to the nearest multiple (e.g.roundArray([0.4, 0.3, 0.3], 1) == [1, 0, 0]).New
--helpoutput:Help-text only; no behaviour changes.
🤖 Generated with Claude Code