Repository navigation
Fix how runlemke() failure is checked in runLH() and runtrace() - #27
Merged
rahulsavani merged 2 commits intoOct 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the solver contract and includes focused regression coverage.
0 open findings
What changed in this PR
Updates bimatrix solvers to correctly detect unsuccessful runlemke() results.
Changes:
- Checks
LcpResult.successinrunLH()andruntrace(). - Adds regression tests for both failure paths.
| File | Description |
|---|---|
src/lemke/bimatrix.py |
Corrects failure detection. |
tests/test_bimatrix_units.py |
Tests unsuccessful solver results. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #23.
Changes:
runlemke()returnsNone, now returned result object'ssuccessfield is verified to beFalse.runLH()andruntrace()throwRuntimeErrorwhenrunlemke()fails unexpectedly.