Skip to content

Fix various issues with sound movement and attenuation #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tisawesomeness wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix various issues with sound movement and attenuation #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
346472d
Boost note volume so locational sounds can be heard across entire range
Tisawesomeness Aug 14, 2026
ba8fe7b
Sounds follow the player
Tisawesomeness Aug 14, 2026
85400f9
Add stereo toggle (sounds following player does not work with stereo)
Tisawesomeness Aug 14, 2026
9395447
Fix empty spaces between buttons
Tisawesomeness Aug 14, 2026
bda05d3
Set default jukebox volume to 100
Tisawesomeness Aug 14, 2026
19618df
Prevent buttons from moving around when switching modes
Tisawesomeness Aug 18, 2026
8c83e0b
Play sounds close to player but in jukebox direction
Tisawesomeness Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/main/java/dev/geco/gmusic/GMusicMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import dev.geco.gmusic.service.message.PaperMessageService;
import dev.geco.gmusic.service.message.SpigotMessageService;
import dev.geco.gmusic.util.EnvironmentUtil;
import dev.geco.gmusic.util.MusicUtil;
import dev.geco.gmusic.util.SteroNoteUtil;
import org.bukkit.Bukkit;
import org.bukkit.command.CommandSender;
Expand Down Expand Up @@ -68,6 +69,7 @@ public class GMusicMain extends JavaPlugin {
private WavConverter wavConverter;
private EnvironmentUtil environmentUtil;
private SteroNoteUtil steroNoteUtil;
private MusicUtil musicUtil;
private GriefPreventionLink griefPreventionLink;
private PlaceholderAPILink placeholderAPILink;
private PlotSquaredLink plotSquaredLink;
Expand Down Expand Up @@ -115,6 +117,8 @@ public class GMusicMain extends JavaPlugin {

public SteroNoteUtil getSteroNoteUtil() { return steroNoteUtil; }

public MusicUtil getMusicUtil() { return musicUtil; }

public GriefPreventionLink getGriefPreventionLink() { return griefPreventionLink; }

public PlaceholderAPILink getPlaceholderAPILink() { return placeholderAPILink; }
Expand Down Expand Up @@ -152,6 +156,7 @@ public void onLoad() {

environmentUtil = new EnvironmentUtil(this);
steroNoteUtil = new SteroNoteUtil();
musicUtil = new MusicUtil(this);

loadFeatures();

Expand Down
7 changes: 7 additions & 0 deletions core/src/main/java/dev/geco/gmusic/model/PlaySettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ public class PlaySettings {
private boolean reverseMode;
private boolean toggleMode;
private long range;
private boolean stereo;
private @NotNull List<Song> favorites;

public PlaySettings(
Expand All @@ -28,6 +29,7 @@ public PlaySettings(
boolean reverseMode,
boolean toggleMode,
long range,
boolean stereo,
@NotNull List<Song> favorites
) {
this.uuid = uuid;
Expand All @@ -39,6 +41,7 @@ public PlaySettings(
this.reverseMode = reverseMode;
this.toggleMode = toggleMode;
this.range = range;
this.stereo = stereo;
this.favorites = favorites;
}

Expand Down Expand Up @@ -76,6 +79,10 @@ public PlaySettings(

public void setRange(long range) { this.range = range; }

public boolean isStereo() { return stereo; }

public void setStereo(boolean stereo) { this.stereo = stereo; }

public @NotNull List<Song> getFavorites() { return favorites; }

public void setFavorites(@NotNull List<Song> favorites) { this.favorites = favorites; }
Expand Down
Loading