Improve custom instrument support by fetching sound event list - #22
Open
Tisawesomeness wants to merge 1 commit into
Open
Improve custom instrument support by fetching sound event list#22Tisawesomeness wants to merge 1 commit into
Tisawesomeness wants to merge 1 commit into
Conversation
Client-side sound paths "minecraft/dig/sand1" or "dig/sand1" are converted to sound events "minecraft:block.sand.break" that can be played server-side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many custom instruments are defined as client-side sound paths, such as
dig/sand1(path in Minecraft assetssoundsdirectory) orminecraft/dig/sand1(default NBS import directory). However, servers do not have access to these sounds, only sound events such asminecraft:block.sand.break.This PR (if enabled) fetches sounds.json for the current Minecraft version and uses it to convert client-side sound paths to server-side sound events, allowing many more custom instruments to be played without having to manually edit the files.