feat: support browser download mirrors - #1333
Conversation
|
@codex review |
✅ Testplane E2E run succeed
|
commit: |
✅ Testplane browser-env run succeed
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7d59b6b to
49aede6
Compare
| "Version examples: '120', '120.0'", | ||
| ].join("\n"), | ||
| mirror | ||
| ? "Couldn't download browser artifact from the configured mirror" |
| let filename: string; | ||
|
|
||
| if (isChannel) { | ||
| const channel = selector === "latest" ? "canary" : selector; |
There was a problem hiding this comment.
why should "latest" be "canary"? is this the same?
There was a problem hiding this comment.
By puppeteer logic, yes
What you probably mean by "latest" is "stable", but "latest" === "canary"
| } | ||
|
|
||
| const data = (await response.json()) as { LATEST_FIREFOX_VERSION?: unknown } | null; | ||
| const version = data?.LATEST_FIREFOX_VERSION; |
There was a problem hiding this comment.
Not quite. Version could be not a string here, so by using "trim" here once we have to throw error twice, so, no difference
68228b6 to
cba8566
Compare
cba8566 to
2f9d36c
Compare
2 participants
No description provided.