Conversation
DudaGod
force-pushed
the
INFRADUTY-30657.reproduce_iframe_assert_view
branch
from
September 25, 2026 06:34
8143c0a to
1cde2e4
Compare
DudaGod
force-pushed
the
INFRADUTY-30657.clip_iframe_bounds
branch
from
September 25, 2026 06:34
7ec49f4 to
eaf8f17
Compare
Base automatically changed from
INFRADUTY-30657.reproduce_iframe_assert_view
to
master
September 28, 2026 14:10
DudaGod
force-pushed
the
INFRADUTY-30657.clip_iframe_bounds
branch
from
September 28, 2026 14:41
eaf8f17 to
ee67611
Compare
✅ Testplane E2E run succeed
|
commit: |
✅ Testplane browser-env run succeed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I intersect the visible and safe capture areas with the content bounds of each enclosing iframe. This prevents Testplane from treating pixels outside a 600 px high frame as visible when it captures a 900 px tall element.
After #1334 was merged, I rebased this change onto
master. I added anassertViewE2E with a tall gradient inside the offset iframe; its reference contains the full 900 px height.Verification after rebase:
npm run buildnpm test— 3,593 passing, 1 pendingassertViewE2E tests — 2 passingParent-page scrolling and fixed overlays are separate existing iframe cases.