Skip to content

feat: upload to ghcr using oras - #98

Open
inffy wants to merge 4 commits into
mainfrom
oras-ghcr
Open

inffy wants to merge 4 commits into
mainfrom
oras-ghcr

Conversation

@inffy

@inffy inffy commented Sep 17, 2026

Copy link
Copy Markdown
Member

Closes #78

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@inffy

inffy commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

seems to be working

oras pull ghcr.io/get-aurora-dev/iso/aurora:stable
✓ Pulled      aurora-stable-x86_64.iso-CHECKSUM                                                                                                                  91/91  B 100.00%  907µs
  └─ sha256:750f40ce5c00cbf9879c3a5ce14a8a28aebc149fa1dade917c9dcd93ac956cda                                                                                                            
✓ Pulled      aurora-stable-x86_64.iso                                                                                                                       6.69/6.69 GB 100.00%  5m29s
  └─ sha256:702e5ce9ce67d9d83f3ae00a15ecd6d717be43316d32a8531de51f3a1838e321                                                                                                            
✓ Pulled      application/vnd.oci.image.manifest.v1+json                                                                                                       844/844  B 100.00%   64µs
  └─ sha256:0680bbee0afb50d24658bf442b1cb4e94e6892aa96cead9e569849a51ac75e4d                                                                                                            
Pulled [registry] ghcr.io/get-aurora-dev/iso/aurora:stable
Digest: sha256:0680bbee0afb50d24658bf442b1cb4e94e6892aa96cead9e569849a51ac75e4d

@inffy
inffy marked this pull request as ready for review September 18, 2026 04:00
@renner0e

Copy link
Copy Markdown
Member

they need to be set public first I think

❯ oras pull ghcr.io/get-aurora-dev/iso/aurora:pr-98-testing
Error response from registry: unauthorized: authentication required

~
❯ oras pull ghcr.io/get-aurora-dev/iso/aurora:stable
Error response from registry: unauthorized: authentication required

~
❯ oras pull ghcr.io/get-aurora-dev/iso/aurora:stable
Error response from registry: unauthorized: authentication required

@inffy

inffy commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

forgot to do that, they are now set to public

@renner0e renner0e left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's see if this actually helps with download speeds, in the future I feel like we shouldn't introduce any more complexity until #94 is done

Comment thread .github/workflows/reusable-build-iso-anaconda.yml Outdated
cosign sign -y "${GHCR_REPO}@${DIGEST}"

# Sign with static key if available
if [[ -n "${COSIGN_PRIVATE_KEY:-}" ]]; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the key is called SIGNING_SECRET

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry not relaly understanding this. We have (just like in aurora) this:
COSIGN_PRIVATE_KEY: ${{ secrets.SIGNING_SECRET }}

@renner0e renner0e left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accidentally approved

@inffy

inffy commented Sep 18, 2026

Copy link
Copy Markdown
Member Author

let's see if this actually helps with download speeds, in the future I feel like we shouldn't introduce any more complexity until #94 is done

Its not that importatn, we can easily draft this until #94 is done and look at it at that time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

additionally upload ISOs in PRs via oras to container registry

2 participants