Repository navigation
ci: move Docker files to sub-folder - #1019
Conversation
This is to prevent Railway using Docker to deploy the development environment
rmdes
left a comment
rmdes
left a comment
There was a problem hiding this comment.
Looks good. I built the branch with docker build -f docker/Dockerfile . and it works, with docker/Dockerfile.dockerignore picked up (a 3.9 MB build context against 14 MB on disk). The other Dockerfile mentions left in the repo are all about the one create-indiekit generates for users, so nothing else needs to move. One knock-on: building from a checkout is now -f docker/Dockerfile rather than a plain docker build .; I'll update the quickstart's instructions once this is merged.
rmdes
left a comment
rmdes
left a comment
There was a problem hiding this comment.
Looks good. I built the branch with docker build -f docker/Dockerfile . and it works, with docker/Dockerfile.dockerignore picked up (a 3.9 MB build context against 14 MB on disk). The other Dockerfile mentions left in the repo are all about the one create-indiekit generates for users, so nothing else needs to move. One knock-on: building from a checkout is now -f docker/Dockerfile rather than a plain docker build .; I'll update the quickstart's instructions once this is merged.
Upstream moved the Dockerfile into docker/ (getindiekit/indiekit#1019), so a bare docker build of the checkout no longer finds it.
This is to prevent Railway using Docker to deploy the development environment. This is important because Railway always picks Docker as builder and
Dockerfilerequiresapp/indiekit.config.jswhich can’t be mounted on Railway.