fix: encode resource identifiers as URL path segments - #422
Open
bm1016bm-svg wants to merge 1 commit into
Open
bm1016bm-svg wants to merge 1 commit into
bm1016bm-svg wants to merge 1 commit into
Conversation
Welcome, @bm1016bm-svg!Thanks for your first contribution! Before we proceed with the review, please sign the Fiduciary License Agreement: Once signed, this PR will be automatically updated. |
Thanks, @bm1016bm-svg! 🎉Your CLA has been signed and is now on file. We'll proceed with the review shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.customers.find("customer#billing")currently builds a URL whose fragment isbilling, so the HTTP request targetscustomerinstead of the supplied external ID. Question marks become query strings, slashes create extra path segments, and literal percent escapes are reinterpreted. The shared URL builder affects both standard and nested resource methods.Encode each raw
path_partselement separately before joining it, leaving query serialization unchanged. Also escape standalone.and.., whichquote()otherwise preserves andurljoinnormalizes away. Callers supply raw identifiers, including literal%characters, rather than pre-encoded URLs.Validation:
python -m pytest -q— 463 passed (three existing deprecation warnings), Python 3.12, HTTPX 0.28.1.raw_pathand authorization header for reserved characters and dot-segment identifiers, plus nested paths and independently encoded query parameters. No live Lago API or customer data is used.git diff --check.This is separate from #410 / #421, which address missing authorization on child-resource listings.
Implemented and tested with OpenAI Codex assistance.