Skip to content

fix(react-native): handle unreadable Xcode sourcemap reports - #1349

Merged
betegon merged 1 commit into
mainfrom
cursor/sentry-cli-bug-fixes-49e9
Sep 23, 2026
Merged

betegon merged 1 commit into
mainfrom
cursor/sentry-cli-bug-fixes-49e9

Conversation

@cursor

@cursor cursor Bot commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

An unreadable or malformed React Native Xcode sourcemap report can replace the build result with an ENOENT or SyntaxError. Catch report read/parse failures, log the error at debug level, and skip uploads while preserving the build script's exit status.

The report is initialized before the build runs; this covers a report that is subsequently removed or corrupted.

Test plan

  • Four regression cases cover missing/malformed reports with successful and failed builds. All four fail against the original implementation and pass with the fix.
  • pnpm exec vitest run test/commands/react-native/xcode.test.ts test/lib/react-native/wrap-call.test.ts — 14 tests passed.
  • Biome checks on the two changed files — passed.
  • git diff --check — passed.
  • No real Xcode build was run locally.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://cli.sentry.dev/_preview/pr-1349/

Built to branch gh-pages at 2026-08-03 12:10 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@github-actions github-actions Bot added the risk: low PR risk score: low label Sep 21, 2026
@betegon
betegon force-pushed the cursor/sentry-cli-bug-fixes-49e9 branch from 06a8e92 to 0cbc53d Compare September 23, 2026 13:48
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cli Ready Ready Preview Sep 23, 2026 2:41pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
sentry-local Skipped Skipped Sep 23, 2026 2:41pm UTC

Request Review

@vercel
vercel Bot temporarily deployed to Preview – sentry-local September 23, 2026 13:49 Inactive
@betegon betegon changed the title fix: three bug fixes — xcode report JSON.parse, upgrade response.json(), seer schema validation fix: handle invalid Xcode reports and validate Seer responses Sep 23, 2026
@betegon
betegon marked this pull request as ready for review September 23, 2026 14:37
@github-actions github-actions Bot added risk: medium PR risk score: medium and removed risk: low PR risk score: low labels Sep 23, 2026
@betegon
betegon force-pushed the cursor/sentry-cli-bug-fixes-49e9 branch from 0cbc53d to e7ae570 Compare September 23, 2026 14:40
@vercel
vercel Bot temporarily deployed to Preview – sentry-local September 23, 2026 14:40 Inactive
@betegon betegon changed the title fix: handle invalid Xcode reports and validate Seer responses fix(react-native): handle unreadable Xcode sourcemap reports Sep 23, 2026
@github-actions github-actions Bot added risk: low PR risk score: low and removed risk: medium PR risk score: medium labels Sep 23, 2026
@betegon
betegon merged commit f9c6cb0 into main Sep 23, 2026
37 of 38 checks passed
@betegon
betegon deleted the cursor/sentry-cli-bug-fixes-49e9 branch September 23, 2026 14:50

This branch was successfully deployed

1 active and 1 inactive deployments
Preview – cli — e7ae5704 Deployed Sep 23, 2026 by vercel[bot]
Preview – sentry-local — e7ae5704 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant