Skip to content

fix: correct codex environment header mapping - #173

Merged
gricha merged 2 commits into
getsentry:mainfrom
mishamilovidov:milovido-adobe-fix-codex-env-http-headers
Sep 8, 2026
Merged

gricha merged 2 commits into
getsentry:mainfrom
mishamilovidov:milovido-adobe-fix-codex-env-http-headers

Conversation

@mishamilovidov

@mishamilovidov mishamilovidov commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

Correct Codex environment HTTP header serialization so authenticated HTTP MCP servers read the intended environment variables.

Changes

  • Map each env_http_headers entry from its HTTP header name to its environment variable name.
  • Update helper and generated-TOML assertions to lock the Codex schema direction.

Testing

  • pnpm check (295 library tests and 806 host tests).
  • Focused Codex header tests (2 files and 51 tests).
  • Non-root Docker lifecycle with Codex CLI 0.152.1 for project install and sync.

Related Issues

Notes

This change only corrects generated env_http_headers. It does not change stdio env_vars or MCP endpoint response handling.

Merge first, before #166, #178, and #177. This Codex MCP fix is independent and gives those branches a common base for their rebases.

Codex expects env_http_headers to map HTTP header names to environment variable names. Reverse the generated entries and cover the serialized TOML shape to fix getsentry#171.
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

@mishamilovidov is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@mishamilovidov
mishamilovidov marked this pull request as ready for review August 24, 2026 17:39
@github-actions github-actions Bot added the risk: low PR risk score: low label Aug 24, 2026
@gricha
gricha merged commit 517964b into getsentry:main Sep 8, 2026
12 of 13 checks passed
mishamilovidov added a commit to mishamilovidov/dotagents that referenced this pull request Sep 8, 2026
Incorporate the Codex HTTP header fix from getsentry#173 while preserving the marketplace naming migration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mishamilovidov added a commit to mishamilovidov/dotagents that referenced this pull request Sep 8, 2026
Incorporate the Codex HTTP header fix from getsentry#173 while preserving the marketplace naming migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: low PR risk score: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Codex env_http_headers reverses header names and environment variable names

2 participants