Conversation
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/cf-int-tests-propagation-streaming
branch
from
September 7, 2026 15:35
fc43397 to
3ea8ff9
Compare
JPeer264
force-pushed
the
jp/cf-int-tests-propagation-streaming
branch
from
September 7, 2026 15:49
3ea8ff9 to
543e4cd
Compare
JPeer264
force-pushed
the
jp/cf-int-tests-propagation-streaming
branch
from
September 7, 2026 16:00
543e4cd to
b8a4481
Compare
JPeer264
force-pushed
the
jp/cf-int-tests-propagation-streaming
branch
from
September 8, 2026 07:40
b8a4481 to
b170bdd
Compare
Removes the `traceLifecycle: 'static'` pin from the twelve `suites/tracing/propagation` suites, and rewrites the assertions from transaction envelopes to span v2. Each hop of a propagated trace runs in its own isolate and streams its own envelope, so a suite reads one segment span per envelope and then checks `trace_id` and `parent_span_id` between them. Most suites keep one envelope expectation per hop with `.unordered()`, which stays close to the shape they had. `worker-service-binding` uses `collectStreamedSpans` instead, because it only needs the two segment spans of one trace. Every route in these suites is a raw URL, so the streamed segment name keeps the method only. `GET /chain` becomes `GET`, and the route is read from the `url.path` attribute. The `sed` that removed the pins took a whole line with it in `worker-workerentrypoint-rpc/index.ts`, where the options callback sat on one line. This restores `LoopbackEntrypoint` with its `tracesSampleRate: 0`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/cf-int-tests-propagation-streaming
branch
from
September 19, 2026 15:46
b170bdd to
a41a0e1
Compare
JPeer264
marked this pull request as ready for review
September 21, 2026 06:44
JPeer264
requested review from
isaacs,
msonnb and
mydea
and removed request for
a team
September 21, 2026 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #24147
This PR is the same as #24179, just for the
/propagationentry. The sole purpose is to reduce the size of the PR