ref(browser)!: Remove the web vital report event attribute - #24511
Merged
Merged
Conversation
LCP and CLS spans set browser.web_vital.{lcp,cls}.report_event to record
whether the SDK finalized the page load value on pagehide or at the first
navigation. Per-navigation web vitals are the default in v11 and never set
it, since web-vitals decides when a value is final on that path. It was
only still emitted with softNavigations and bfcacheNavigations turned off.
The logic that finalizes on pagehide or navigation stays, it is still what
the opt-out path uses. It just no longer reports which of the two fired.
Contributor
size-limit report 📦
|
logaretm
marked this pull request as ready for review
September 21, 2026 18:40
logaretm
requested review from
Lms24 and
msonnb
and removed request for
a team
September 21, 2026 18:40
Lms24
approved these changes
Sep 21, 2026
Lms24
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-navigation web vitals are the default in v11 and never set
browser.web_vital.{lcp,cls}.report_event, so only opt-out users still got it, so this PR cleans up those attributes.Maybe a v12 thing given there is path for these to be reported.