fix(core): Stop sending client reports for breadcrumbs - #24537
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bb9bfe6. Configure here.
Contributor
size-limit report 📦
|
Lms24
requested review from
a team,
chargome,
logaretm and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
September 21, 2026 10:37
chargome
approved these changes
Sep 21, 2026
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
{ reason: 'buffer_overflow', category: 'log_item' }client report the SDK sent when the breadcrumbs buffer (100 breadcrumbs limit) overflowed and we evicted breadcrumbs.Why? When we started working on logs, we wanted to know how many breadcrumbs we currently discard due to the 100 crumbs limit. We used the new
log_itemdata category for this andbuffer_overflowreason. Later on, we added client reports for actual log discards and re-used this data category but sent different reasons. Meaning different telemtry items now fall into the same discard bucket as reported in #24510.Since I don't think we still need to know about breadcrumb discards, and they're not their own telemetry items but part of errror and transaction events, I think we can just stop emitting client reports for them.
closes #24510