fix: disable signal-safe stderr logging on PlayStation - #2133
Merged
Merged
Conversation
tustanivsky
marked this pull request as ready for review
September 23, 2026 13:37
jpnurmi
approved these changes
Sep 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
=======================================
Coverage 75.44% 75.44%
=======================================
Files 103 103
Lines 28026 28026
Branches 5114 5114
=======================================
+ Hits 21143 21145 +2
+ Misses 5549 5547 -2
Partials 1334 1334 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SENTRY_SIGNAL_SAFE_LOGwrites to stderr withwrite(). On PlayStation, doing that from the coredump handler crashes the handler (Debug handler crashed … 0xa002030a). When that happens, the crash dump is uploaded without Sentry's userdata, so the event has no SDK context: no release, tags, breadcrumbs or attachments.This became visible in 0.17.0. #2112 added
sentry__invoke_on_crash, which logs before calling the hook, and the PlayStation backend now calls it from the coredump handler. Any app with anon_crashcallback, including every Unreal Engine game, loses its crash context.This PR makes the macro a no-op on
SENTRY_PLATFORM_PS, the same way it already is on other platforms that are neither Unix nor Windows. The PlayStation backend already turns off regular logging inside the handler for the same reason.Verified on a PS5 devkit with sentry-playstation's integration tests, using an app that registers
on_crash: crash-capture fails on 0.17.0 and passes with this change.