Skip to content

ref(mcp): Inline _prepare_handler_data() - #6758

Merged
alexander-alderman-webb merged 18 commits into
masterfrom
webb/mcp/use-middleware
Jul 28, 2026
Merged

ref(mcp): Inline _prepare_handler_data()#6758
alexander-alderman-webb merged 18 commits into
masterfrom
webb/mcp/use-middleware

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description

Remove unnecessary indirection by inlining _prepare_handler_data().

Issues

Reminders

Comment thread sentry_sdk/integrations/mcp.py Outdated
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98741 passed | ⏭️ 6806 skipped | Total: 105547 | Pass Rate: 93.55% | Execution Time: 361m 15s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +2
Failed Tests 📉 -2
Skipped Tests

➖ Removed Tests (2)

View removed tests
  • test_circular_references_span_streaming
    • File: tests.tracing.test_misc
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-thread]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

❌ Patch coverage is 30.00%. Project has 2560 uncovered lines.
❌ Project coverage is 89.56%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/mcp.py 30.00% ⚠️ 14 Missing
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.60%    89.56%    -0.04%
==========================================
  Files          193       193         —
  Lines        24529     24531        +2
  Branches      8676      8678        +2
==========================================
+ Hits         21979     21971        -8
- Misses        2550      2560       +10
- Partials      1400      1400         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb changed the title ref(mcp): Use middleware when available ref(mcp): Inline _prepare_handler_data() Jul 6, 2026
Comment thread sentry_sdk/integrations/mcp.py
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 7, 2026 11:10
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 7, 2026 11:10
Base automatically changed from webb/mcp/seperate-handlers to master July 28, 2026 07:11

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9cd03cf. Configure here.

Comment thread sentry_sdk/integrations/mcp.py
@alexander-alderman-webb
alexander-alderman-webb merged commit 73b43a9 into master Jul 28, 2026
140 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/mcp/use-middleware branch July 28, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants