test(fastmcp): Remove assertions on RootModel instances - #6909
Merged
Conversation
Contributor
Codecov Results 📊✅ 98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 350m 52s 📊 Comparison with Base Branch
➖ Removed Tests (3)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2499 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.84% 89.84% —%
==========================================
Files 193 193 —
Lines 24588 24588 —
Branches 8744 8744 —
==========================================
+ Hits 22089 22089 —
- Misses 2499 2499 —
- Partials 1400 1400 —Generated by Codecov Action |
alexander-alderman-webb
changed the base branch from
master
to
webb/mcp-remove-stdio-transactions
July 29, 2026 09:23
alexander-alderman-webb
changed the base branch from
webb/mcp-remove-stdio-transactions
to
master
July 29, 2026 11:17
alexander-alderman-webb
changed the base branch from
master
to
webb/fastmcp-try-except
July 29, 2026 11:53
alexander-alderman-webb
marked this pull request as ready for review
July 29, 2026 12:26
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a3d4b29. Configure here.
sentrivana
approved these changes
Jul 29, 2026
root property in handler results
root property in handler resultsRootModel instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Remove assertions that fail on the pre-release of
fastmcpto avoid disproportionate complexity in the test suite.The tests depend on the return type, and implicitly check non-interference of the SDK.
The cause is this breaking change in
mcpwith their major: https://github.com/modelcontextprotocol/python-sdk/blob/6f69a3758ebf2ee55ce050f58b470ce11af71133/docs/migration.md?plain=1#L420Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)