Skip to content

test(fastmcp): Remove assertions on RootModel instances - #6909

Merged
alexander-alderman-webb merged 25 commits into
masterfrom
webb/fastmcp-types
Jul 29, 2026
Merged

test(fastmcp): Remove assertions on RootModel instances#6909
alexander-alderman-webb merged 25 commits into
masterfrom
webb/fastmcp-types

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Description

Remove assertions that fail on the pre-release of fastmcp to avoid disproportionate complexity in the test suite.
The tests depend on the return type, and implicitly check non-interference of the SDK.

The cause is this breaking change in mcp with their major: https://github.com/modelcontextprotocol/python-sdk/blob/6f69a3758ebf2ee55ce050f58b470ce11af71133/docs/migration.md?plain=1#L420

Issues

Reminders

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 350m 52s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +3
Failed Tests 📉 -3
Skipped Tests

➖ Removed Tests (3)

View removed tests
  • test_segment_uses_downsampled_rate
    • File: tests.test_monitor
  • test_trace_decorator_no_trx
    • File: tests.tracing.test_decorator
  • test_continuous_profiler_auto_start_and_stop_sampled[experiment-thread]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2499 uncovered lines.
✅ Project coverage is 89.84%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.84%    89.84%        —%
==========================================
  Files          193       193         —
  Lines        24588     24588         —
  Branches      8744      8744         —
==========================================
+ Hits         22089     22089         —
- Misses        2499      2499         —
- Partials      1400      1400         —

Generated by Codecov Action

Base automatically changed from webb/add-httpx-dependency-mcp to master July 29, 2026 06:31
@alexander-alderman-webb
alexander-alderman-webb changed the base branch from master to webb/mcp-remove-stdio-transactions July 29, 2026 09:23
@alexander-alderman-webb
alexander-alderman-webb changed the base branch from webb/mcp-remove-stdio-transactions to master July 29, 2026 11:17
@alexander-alderman-webb
alexander-alderman-webb changed the base branch from master to webb/fastmcp-try-except July 29, 2026 11:53
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 29, 2026 12:26
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 29, 2026 12:26
Comment thread tests/integrations/fastmcp/test_fastmcp.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a3d4b29. Configure here.

Comment thread tests/integrations/fastmcp/test_fastmcp.py
Base automatically changed from webb/fastmcp-try-except to master July 29, 2026 13:05
@alexander-alderman-webb alexander-alderman-webb changed the title test(fastmcp): Remove assertions on root properties in handler results test(fastmcp): Remove assertions on root property in handler results Jul 29, 2026
@alexander-alderman-webb alexander-alderman-webb changed the title test(fastmcp): Remove assertions on root property in handler results test(fastmcp): Remove assertions on RootModel instances Jul 29, 2026
@alexander-alderman-webb
alexander-alderman-webb merged commit bb49081 into master Jul 29, 2026
145 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/fastmcp-types branch July 29, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants