Skip to content

ref(mcp): Remove redundant mcp.tool.result.is_error - #6915

Merged
alexander-alderman-webb merged 30 commits into
masterfrom
webb/remove-mcp-tool-result-is_error
Jul 29, 2026
Merged

ref(mcp): Remove redundant mcp.tool.result.is_error#6915
alexander-alderman-webb merged 30 commits into
masterfrom
webb/remove-mcp-tool-result-is_error

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

The attribute is redundant with the captured exception, and is deprecated anyway.

Issues

Reminders

@alexander-alderman-webb alexander-alderman-webb changed the title ref(mcp): Remove redundant mcp.tool.result.is_error ref(mcp): Remove redundant mcp.tool.result.is_error Jul 29, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 355m 23s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +32
Passed Tests 📈 +32
Failed Tests 📉 -1
Skipped Tests 📈 +1

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2499 uncovered lines.
✅ Project coverage is 89.84%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.84%    89.84%        —%
==========================================
  Files          193       193         —
  Lines        24588     24587        -1
  Branches      8744      8744         —
==========================================
+ Hits         22089     22088        -1
- Misses        2499      2499         —
- Partials      1400      1400         —

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 29, 2026 12:26
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 29, 2026 12:26
Base automatically changed from webb/fastmcp-types to master July 29, 2026 13:22
Comment thread sentry_sdk/integrations/mcp.py
@alexander-alderman-webb
alexander-alderman-webb merged commit 3cf5824 into master Jul 29, 2026
271 of 273 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/remove-mcp-tool-result-is_error branch July 29, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants