Skip to content

test(fastmcp): Replace broad try...except with skipif - #6922

Merged
alexander-alderman-webb merged 4 commits into
masterfrom
webb/fastmcp-try-except
Jul 29, 2026
Merged

test(fastmcp): Replace broad try...except with skipif#6922
alexander-alderman-webb merged 4 commits into
masterfrom
webb/fastmcp-try-except

Conversation

@alexander-alderman-webb

Copy link
Copy Markdown
Contributor

Description

Broad try...except blocks can mask other problems and makes the test hard to maintain.

Issues

Reminders

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 352m 58s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📉 -16
Failed Tests
Skipped Tests 📈 +16

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2499 uncovered lines.
✅ Project coverage is 89.84%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.84%    89.84%        —%
==========================================
  Files          193       193         —
  Lines        24588     24588         —
  Branches      8744      8744         —
==========================================
+ Hits         22089     22089         —
- Misses        2499      2499         —
- Partials      1400      1400         —

Generated by Codecov Action

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review July 29, 2026 12:26
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner July 29, 2026 12:26

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eb76bfa. Configure here.

Comment thread tests/integrations/fastmcp/test_fastmcp.py
Comment thread tests/integrations/fastmcp/test_fastmcp.py
@alexander-alderman-webb
alexander-alderman-webb merged commit 8393b88 into master Jul 29, 2026
145 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/fastmcp-try-except branch July 29, 2026 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants