fix: HTTP transport on Mono with high stripping - #2858
Draft
bitsandfoxes wants to merge 2 commits into
Draft
bitsandfoxes wants to merge 2 commits into
bitsandfoxes wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surfaced by #2854. That's the first time the Windows Mono job ran on Unity 6, where we build with
Highstripping.On Mono,
HttpWebRequestspins up the configuration system, which createsExeConfigurationHostand themachine.configsection types via reflection. The linker can't see that and strips them. So every envelope fails to send withDefault constructor not found for type System.Configuration.ExeConfigurationHost. This isn't Sentry-specific, but it takes out our transport.Unity ignores
link.xmlfiles inside packages, and we stopped writing one intoAssets/back in #707. So we're now providing the rules at build time viaIUnityLinkerProcessor, and only for Mono.The DependencyConflict package also breaks on Mono +
Highstripping (FieldAccessExceptionin its own unaliasedSystem.Text.Json). That's not ours to fix and Sentry doesn't go through that path, so it's skipped on the Mono job for now.🤖 Generated with Claude Code