Repository navigation
terminal/tmux: parse %output without a regex - #14947
Merged
Merged
Conversation
Parse `%output %<pane> <data>` by hand instead of compiling an Oniguruma regex for every pane write, matching how %window-close and %session-window-changed are already parsed. The pane id now goes through parseDecimalId, so an id that overflows usize is logged and dropped rather than hitting `catch unreachable`. Empty data is accepted rather than rejected. The data is sliced from the line directly rather than through std.mem.cutPrefix, which returns a const slice, so that it keeps the mutability of the parser buffer it points into.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse
%output %<pane> <data>by hand instead of compiling an Oniguruma regex for every pane write, matching how %window-close and %session-window-changed are already parsed.The pane id now goes through parseDecimalId, so an id that overflows usize is logged and dropped rather than hitting
catch unreachable. Empty data is accepted rather than rejected.AI disclosure: Claude Code was used in the preparation of this PR.