Repository navigation
Conversation
mitchellh
approved these changes
Oct 31, 2026
Contributor
|
Some failing CI. |
The Zig 0.17 port switched reportPwd from `uri.getHost` to `std.Io.net.HostName.fromUri`, which also validates the host as an RFC 1123 hostname. Local hostnames often aren't: macOS allows names like "Foo's MacBook Pro", some systems use underscores, and our URI parser deliberately accepts MAC addresses. Any OSC 7 report from such a machine was dropped, so new tabs, splits and windows stopped inheriting the working directory. The host only has to match the local hostname, which `isLocal` already checks, so extract it without validating it, as 1.3 did. Fixes: ghostty-org#14970 Ref: ghostty-org#14952
jcollie
force-pushed
the
osc7-hostname-validation
branch
from
October 31, 2026 05:44
bd223c5 to
f7b25c8
Compare
jcollie
enabled auto-merge
October 31, 2026 05:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Zig 0.17 port switched reportPwd from
uri.getHosttostd.Io.net.HostName.fromUri, which also validates the host as an RFC 1123 hostname. Local hostnames often aren't: macOS allows names like "Foo's MacBook Pro", some systems use underscores, and our URI parser deliberately accepts MAC addresses. Any OSC 7 report from such a machine was dropped, so new tabs, splits and windows stopped inheriting the working directory.The host only has to match the local hostname, which
isLocalalready checks, so extract it without validating it, as 1.3 did.Fixes: #14970
Ref: #14952
AI disclosure: Claude Code was used in the preparation of this PR.