Repository navigation
fix(docs): avoid EasyList hiding desktop-notifications heading - #493
Open
SatvikMishra08 wants to merge 1 commit into
Open
SatvikMishra08 wants to merge 1 commit into
SatvikMishra08 wants to merge 1 commit into
Conversation
EasyList/Fanboy Annoyances ships a global ###desktop-notifications cosmetic filter for notification-permission nags. That same id is used for the config reference heading, so uBlock users never see the section and the TOC link is a no-op (ghostty-org#387). Remap the heading id to config-desktop-notifications while keeping the displayed option name unchanged. Fixes ghostty-org#387
|
@SatvikMishra08 is attempting to deploy a commit to the Ghostty Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The config reference heading for
desktop-notificationsused the HTML id#desktop-notifications. EasyList / Fanboy Annoyances ships a global cosmetic filter###desktop-notifications(notification-permission nags), so with uBlock Origin enabled the section is hidden and the TOC link does nothing — as reported in #387.This remaps that heading id to
config-desktop-notificationsin the shared heading-id helpers (TOC + rendered anchors). The displayed option name is unchanged.Fixes #387
Test plan
/docs/config/referenceand confirm thedesktop-notificationsheading is visible