Make Cowork mobile browser test portable - #21
Merged
Conversation
Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Uses an in-page DOM click for the already-visible mobile Settings control so Puppeteer does not depend on platform-specific clickable-point geometry. The same UI event handler and all subsequent mobile viewport assertions remain exercised.
Verification
node --test test/cowork-browser.mjson Linux: 1/1node --test test/cowork-browser.mjson the Apple Silicon release host: 1/1git diff --checkThe clean 0.0.17 Mac release gate discovered this portability failure before packaging; the artifact will be rebuilt only after this PR is green and merged.