Skip to content

[WIP] Fix failing GitHub Actions job for integration add with dispatch-workflow#40109

Merged
pelikhan merged 3 commits into
mainfrom
copilot/fix-integration-add-job-failure
Jun 19, 2026
Merged

[WIP] Fix failing GitHub Actions job for integration add with dispatch-workflow#40109
pelikhan merged 3 commits into
mainfrom
copilot/fix-integration-add-job-failure

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Fix the failing GitHub Actions job "Integration Add with dispatch-workflow Dependencies"
Analyze the Actions logs, identify the root cause of the failure, and implement a fix.
Check run ID: 82167320532
Job URL: https://github.com/github/gh-aw/actions/runs/27770048521/job/82167320532

Copilot AI and others added 2 commits June 18, 2026 16:40
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hey @Copilot 👋 — thanks for tackling the flaky integration test for dispatch-workflow dependencies! Pinning the workflow spec to the last public revision before private: true was added is a sensible fix.

One thing to address before this is ready for review:

  • Update the PR description — the body is still the Copilot boilerplate placeholder ("Thanks for asking me to work on this..."). Replace it with a brief summary of what changed (test-dispatcher.md@main → pinned commit), why (the @main ref broke when private: true was set in e8ca23ae1d), and any known trade-offs (e.g. the pin will need to be bumped if the fixture workflow ever changes again).

If you'd like a hand, here's a prompt you can run:

Update the PR body for github/gh-aw#40109 to replace the Copilot boilerplate with a concise description covering:
1. What changed: the workflow spec in TestAddWorkflowWithDispatchWorkflowDependency was updated from `@main` to the pinned commit `6d18ddf01ec9aaac84f679ebecfcf6d66aa31153`.
2. Why: the `@main` ref started resolving to a revision where `private: true` was set (introduced in e8ca23ae1d), causing the integration test to fail.
3. Trade-off: the pinned commit will need to be updated if the test fixture workflow changes in the future.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • patchdiff.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "patchdiff.githubusercontent.com"

See Network Configuration for more information.

Generated by ✅ Contribution Check ·

@pelikhan pelikhan marked this pull request as ready for review June 19, 2026 00:13
Copilot AI review requested due to automatic review settings June 19, 2026 00:13
@pelikhan pelikhan merged commit 7d2f447 into main Jun 19, 2026
@pelikhan pelikhan deleted the copilot/fix-integration-add-job-failure branch June 19, 2026 00:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix the failing CI job “Integration Add with dispatch-workflow Dependencies” by pinning the remote workflow used by TestAddWorkflowWithDispatchWorkflowDependency to a revision before private: true was introduced, so gh aw add can still fetch the workflow and its dispatch-workflow dependency during integration testing.

Changes:

  • Replace the @main workflow reference with a pinned revision for .github/workflows/test-dispatcher.md in the integration test.
  • Add inline comments explaining why the workflow spec is pinned (to avoid the private: true change).
Show a summary per file
File Description
pkg/cli/add_integration_test.go Updates the dispatch-workflow add integration test to use a pinned upstream workflow revision instead of @main.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment on lines +1000 to +1002
// Pin to the last public revision (6d18ddf01ec9aaac84f679ebecfcf6d66aa31153)
// before private: true was added in e8ca23ae1d.
workflowSpec := "github/gh-aw/.github/workflows/test-dispatcher.md@6d18ddf01ec9aaac84f679ebecfcf6d66aa31153"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants