Fold the Reports package into core (5 -> 4 packages) - #3
Merged
Conversation
DotnetMatplotlib.Reports had no dependencies beyond the core library, so shipping it as its own package was unnecessary surface area. Move Report.fs into the DotnetMatplotlib (facade) project; the published set is now four: DotnetMatplotlib, .Interactive, .Mcp, .DataFrame. The Report type keeps its Matplotlib.Reports namespace, so `open Matplotlib.Reports` is unchanged -- it just ships inside the core DotnetMatplotlib package now. Removed the project from the solution, the test project references, and the publish workflow; updated README / nuget README / PORTING / CHANGELOG. Full suite 161 passing.
There was a problem hiding this comment.
Pull request overview
This pull request folds the formerly separate DotnetMatplotlib.Reports package into the core DotnetMatplotlib package by moving Report into the Matplotlib (facade) project while preserving the Matplotlib.Reports namespace for consumers.
Changes:
- Moved
Report.fsintosrc/Matplotliband included it inMatplotlib.fsproj. - Removed the
Matplotlib.Reportsproject from the solution, tests, and publish workflow. - Updated docs (README, NuGet README, PORTING, CHANGELOG) to reflect the package consolidation and migration steps.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Matplotlib.Tests/Matplotlib.Tests.fsproj | Drops the test project reference to the removed Matplotlib.Reports project. |
| src/Matplotlib/Report.fs | Introduces Matplotlib.Reports.Report in the core assembly. |
| src/Matplotlib/Matplotlib.fsproj | Compiles Report.fs as part of the DotnetMatplotlib package and bundles needed project refs. |
| src/Matplotlib.Reports/Matplotlib.Reports.fsproj | Removes the standalone reports package project file. |
| README.md | Updates usage/docs to indicate Report ships in the core package. |
| PORTING.md | Updates the capability/package mapping for reports to reflect consolidation into core. |
| nuget/README.md | Updates NuGet package README to reference Report as part of the core package. |
| DotnetMatplotlib.slnx | Removes Matplotlib.Reports from the solution. |
| CHANGELOG.md | Adds an Unreleased entry documenting the package consolidation and migration. |
| .github/workflows/publish.yml | Stops restoring/packing the removed DotnetMatplotlib.Reports package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Resolves the CHANGELOG [Unreleased] conflict by keeping both entries: Verso notebook support (Added) and the Reports -> core fold (Changed). All other files auto-merged. Merged state: 4 packages (DotnetMatplotlib with Report, .Interactive with Verso, .Mcp, .DataFrame); 166 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotnetMatplotlib.Reports had no dependencies beyond the core library, so shipping it as its own package was unnecessary surface area. Move Report.fs into the DotnetMatplotlib (facade) project; the published set is now four: DotnetMatplotlib, .Interactive, .Mcp, .DataFrame.
The Report type keeps its Matplotlib.Reports namespace, so
open Matplotlib.Reportsis unchanged -- it just ships inside the core DotnetMatplotlib package now. Removed the project from the solution, the test project references, and the publish workflow; updated README / nuget README / PORTING / CHANGELOG. Full suite 161 passing.