Skip to content

The Office three, and the one shortfall they share #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannevaled merged 1 commit into from
Oct 11, 2026
Merged

The Office three, and the one shortfall they share #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,9 +766,9 @@ bentoparity -tools ~/src/bentopdf/docs/tools -pdfops ./pdfops -src ~/src/go-pdfk
```

```
covered 77
not covered 37
parity 67.5% (77/114), every claim verified
covered 79
not covered 35
parity 69.3% (79/114), every claim verified
```

⛔ **It refuses to report a figure if a single claim cannot be checked.** A
Expand Down
16 changes: 16 additions & 0 deletions parity/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,22 @@ var BentoPDF = []Claim{
// a "go-ooxml/ooxml exists" claim would go on saying yes after the Word
// reader had been dropped in favour of the other two.
{Tool: "word-to-pdf", Claim: "go-ooxml/ooxml#func ParseWord"},
{Tool: "excel-to-pdf", Claim: "go-ooxml/ooxml#func ParseWorkbook"},
{Tool: "powerpoint-to-pdf", Claim: "go-ooxml/ooxml#func ParsePresentation"},

// ⛔ THE SAME SHORTFALL IN ALL THREE, named rather than passed over: each
// of BentoPDF's three Office tools takes the pre-2007 BINARY format as
// well, and nothing in the fleet reads one. They are OLE compound files —
// a different container entirely from OPC, with its own FAT and its own
// record streams — so this is a gap of one missing library and not of
// three missing readers.
//
// word-to-pdf DOC (and DOCX ✓, ODT ✓, RTF ✓)
// excel-to-pdf XLS (and XLSX ✓, ODS ✓, CSV ✓)
// powerpoint-to-pdf PPT (and PPTX ✓, ODP ✓)
//
// Writing it down the way cbz-to-pdf names CBR: a claim whose shortfall is
// written down can be closed by whoever reads it, and the three share one.
{Tool: "markdown-to-pdf", Claim: "go-richdoc/markdown#func Parse"},

// --- the data formats, through go-richdoc/data -------------------------
Expand Down
Loading