Skip to content

The grids the text lines up into: extract-tables and pdf-to-csv #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannevaled merged 1 commit into from
Oct 12, 2026
Merged

The grids the text lines up into: extract-tables and pdf-to-csv #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,9 +766,9 @@ bentoparity -tools ~/src/bentopdf/docs/tools -pdfops ./pdfops -src ~/src/go-pdfk
```

```
covered 82
not covered 32
parity 71.9% (82/114), every claim verified
covered 84
not covered 30
parity 73.7% (84/114), every claim verified
```

⛔ **It refuses to report a figure if a single claim cannot be checked.** A
Expand Down
13 changes: 13 additions & 0 deletions parity/table.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,19 @@ var BentoPDF = []Claim{

// --- what comes OUT of a PDF -------------------------------------------
{Tool: "pdf-to-text", Claim: "verb:text"},
// ⛔ Both of these are the SAME detector, and it is an inference: a page
// holds text put at places, and a table is what a reader sees when those
// places line up. BentoPDF's own two pages are the same thing twice as
// well — extract-tables writes one file per table, pdf-to-csv writes all
// of them into one — and `pdfops tables` does both, with -to and without.
//
// What it does NOT do is read ruled lines, which is the strategy
// PyMuPDF's find_tables uses by DEFAULT and falls back from. So a table
// held apart by rules rather than by whitespace is not found, and the
// claim is for the text strategy alone. Said in extract's README under
// "What it still gets wrong", and in ops's beside the verb.
{Tool: "extract-tables", Claim: "verb:tables"},
{Tool: "pdf-to-csv", Claim: "verb:tables"},
{Tool: "extract-images", Claim: "verb:images"},
{Tool: "extract-attachments", Claim: "verb:detach"},
{Tool: "add-attachments", Claim: "verb:attach"},
Expand Down
Loading