Repository navigation
A FictionBook becomes a PDF: fb2-to-pdf - #114
Merged
Merged
Conversation
go-richdoc/fb2 v0.1.0 reads FictionBook 2 into richdoc, which go-pdfkit composes, so the claim is the reader rather than a new verb -- the same shape as markdown-to-pdf and the four data formats. covered 90 not covered 24 parity 78.9% (90/114), every claim verified pasted from the tool, with fb2 checked out in -src so the symbol claim is read from the Go source and not from this message. ⛔ The claim names `func Parse` rather than the repository, for the reason every other converter claim does: a "go-richdoc/fb2 exists" claim would go on saying yes after the reader had been dropped. ⛔ EPUB and MOBI stay in the uncovered list rather than being folded into "ebooks". FictionBook is the one ebook format a reader can do with encoding/xml alone -- a single XML file, no ZIP, no package document, no spine, images base64 in the same file -- while those two each need an HTML reader into richdoc, which nothing in the fleet has yet. Naming the gap is how it gets closed; absorbing it into a vague claim is how it does not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-richdoc/fb2 v0.1.0 reads FictionBook 2 into richdoc, which go-pdfkit composes — so the claim is the reader, not a new verb, the same shape as
markdown-to-pdfand the four data formats.Pasted from the tool, with
fb2checked out in-srcso the symbol claim is read from the Go source and not from this description.⛔ The claim names
func Parserather than the repository, for the reason every other converter claim does: a "go-richdoc/fb2 exists" claim would go on saying yes after the reader had been dropped.⛔ EPUB and MOBI stay in the uncovered list rather than being folded into "ebooks". FictionBook is the one ebook format a reader can do with
encoding/xmlalone — a single XML file, no ZIP, no package document, no spine, images base64 in the same file — while those two each need an HTML reader into richdoc, which nothing in the fleet has yet. Naming the gap is how it gets closed; absorbing it into a vague claim is how it does not.🤖 Generated with Claude Code