Repository navigation
go 1.27.1, which is what CI has been building with - #94
Merged
Merged
Conversation
The go directive said 1.26.4 while every lane of this repository's CI pins go-version 1.27.1. The version declared and the version tested had not been the same for weeks. Measured on a sibling where the pin was still 1.26 (go-images/jpeg2000#28), govulncheck on the same code: toolchain in packages imported in modules required go1.26.4 1 10 go1.27.1 0 0 Nothing was CALLED in either case; what 1.26.4 carries is its own standard library -- GO-2026-4970 in os, and GO-2026-6218, 6091, 6090, 6089, 6088, 5972, 5942, 5026 and 5856 in stdlib, fixed across 1.26.5 and 1.26.6. govulncheck on this module is silent under 1.27.1: x/sys is already v0.48.0 here, past GO-2026-5024. 1.27.1 and not 1.27, because that is the style this file already used and the advisories are patch-level: "1.27" would admit a toolchain with none of 1.27.1's fixes. go vet, the whole suite and exact 100% coverage pass under 1.27.1, and 1.27's gofmt wants nothing this tree does not already have -- checked, because a note of mine records 1.27 reindenting where the local gofmt cannot see it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One line of
go.mod, and the reason is measured.What was inconsistent
The
godirective said 1.26.4 while every lane of this repository's CI pinsgo-version: "1.27.1". The version the module declared and the version itwas tested with had not been the same for weeks, and a consumer reading
go.modwas told it could build this with a toolchain nothing here exercises.The security case, measured on a sibling
go-images/jpeg2000still pinned"1.26", so it is where the difference couldbe measured.
govulncheck, same code, two toolchains:go1.26.4go1.27.1Nothing was ever called — "your code is affected by 0 vulnerabilities" in both
— so this is what the toolchain carries. Named:
govulncheckon this module is silent under 1.27.1:golang.org/x/sysisalready v0.48.0 here, which is past GO-2026-5024.
Why
1.27.1and not1.27That is the style this file already used, and the advisories above are
patch-level:
go 1.27would admit a toolchain with none of 1.27.1's fixes.Checks
go vet, the whole suite, exact 100% coverage andgofmtall pass under1.27.1 — which is the toolchain CI already uses. This changes what is
declared, not what is tested.
Independent of #92; touches
go.modonly.🤖 Generated with Claude Code