Repository navigation
Lines and Join are the same rule, so they are exported rather than copied - #19
Merged
Merged
Conversation
…pied go-pdfkit/document has to know where a paragraph ends and which line is a heading, and both questions start from the lines of a page. Writing a second line-grouping rule there would mean two rules that must agree about what a page says, with nothing to make them -- so Text's own rule is exported instead. The test is the agreement itself: Lines joined with Join must read exactly what Assemble reads. A copy could pass its own tests and still disagree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-pdfkit/documenthas to know wherea paragraph ends and which line is a heading, and both questions start from the
lines of a page.
Writing a second line-grouping rule there would mean two rules that must
agree about what a page says, with nothing to make them. So
Text's own ruleis exported instead:
The test is the agreement itself —
Linesjoined withJoinmust read exactlywhat
Assemblereads. A copy could pass its own tests and still disagree.Two one-line wrappers over
groupIntoLinesandjoinLine, which already didthis for
Text. 100% of statements, no uncovered blocks.🤖 Generated with Claude Code