Repository navigation
A mark, not the same mark twice - #21
Merged
Merged
Conversation
The bullet rule asked for ONE repeated mark, and that was the wrong question twice over. it read "• • - -" as a table of four rows, because the bullets were not all the same character -- and a reader sees two lists there. go-pdfkit/document found this: it could not make a list of what extract had already called a table. it read a first column of "A" and "A" as an ornament, because "A" is one character and it repeated. A label is data. On a 6-page technical paper that silently cost a table; the same paper now reports 15 where it reported 14, and the extra one is real. The question is whether the column carries INFORMATION. A mark of one or two characters with no letter and no digit in it does not: "-" carries exactly as little as "•". A letter or a digit does: "A"/"B" are labels, "1."/"2." are a numbering somebody may want, "90"/"91" are years, and taking those would be deciding that a table of dates is a list. The 213-page bullet-list document is unchanged at 40 tables, which is the control the rule was written against in the first place. `seen` went with it: dropEmptyColumns has already taken away the columns nothing was drawn in, so "found no mark at all" was a state nothing could reach. The invariant is named where the loop ends instead. 100% of statements, no uncovered blocks, 9 mutations caught. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bullet rule asked for one repeated mark, and that was the wrong
question twice over.
• • - -as a table of four rowsextracthad already called a table.AandAas an ornamentAis one character and it repeated. A label is data. On a 6-page technical paper that silently cost a table.The question is whether the column carries information.
-carries exactly as little as•;A/Bare labels,1./2.are a numberingsomebody may want,
90/91are years. Taking those would be deciding thata table of dates is a list.
Measured
The 6-page paper now reports 15 tables where it reported 14, and the extra
one is real. The 213-page bullet-list document is unchanged at 40, which is
the control this rule was written against in the first place.
A spot check of the paper's first page, which is the reason the rule matters:
A dead guard went with it
seenreported "found no mark at all", anddropEmptyColumnshas alreadytaken away the columns nothing was drawn in — so nothing could reach that
state. The invariant is named where the loop ends instead of being tested
where it cannot happen.
100% of statements, no uncovered blocks, 9 mutations caught.
🤖 Generated with Claude Code