Repository navigation
TablesInRuns: a caller who knows more can take the lines out first - #22
Merged
Merged
Conversation
A numbered heading above a table leaves a gap after its number; the table below it leaves that same gap empty on every row; so the two become ONE two-column table -- and the real four-column table under it is lost, because the heading's own text reaches across every one of its boundaries. Measured on a 6-page technical paper: page 2's four-column comparison came back as two columns, the first of them holding "2." and nothing else. Nothing in the ALIGNMENT says that line is a heading. Its SIZE says so, and what counts as a heading size is a property of the whole document -- which is go-pdfkit/document's business, not this package's. So the detection is exposed over runs the caller chose, and the caller who knows takes the line out and asks again. The test asserts BOTH readings of the same page: the swallowed two-column one when asked about the page, and the four-column one when asked about the runs below the heading. A test that only asserted the second would not show what the first costs. 100% of statements, no uncovered blocks. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A numbered heading above a table leaves a gap after its number; the table below
it leaves that same gap empty on every row; so the two become one two-column
table — and the real four-column table under it is lost, because the
heading's own text reaches across every one of its boundaries.
Measured on a 6-page technical paper. Page 2's four-column comparison came back
like this:
Nothing in the alignment says that line is a heading. Its size says so,
and what counts as a heading size is a property of the whole document — which
is go-pdfkit/document's business, not
this package's. So the detection is exposed over runs the caller chose:
The test asserts both readings of the same page: the swallowed two-column
one when asked about the page, and the four-column one when asked about the
runs below the heading. A test that only asserted the second would not show
what the first costs.
100% of statements, no uncovered blocks.
🤖 Generated with Claude Code