Repository navigation
Import the landing kit as a Hugo module instead of a variant copy - #24
Merged
Merged
Conversation
The page carried its own styles.html: the shared sheet without the fork ribbon's rules. It now imports github.com/go-fleettools/landingkit v0.2.0 (hugo.toml [module], go.mod, kit.go, setup-go before Hugo), as the reference landing does. [params.brand] is generated by `landingkit brand static/img/logo.svg`, replacing the hand-derived block: deep is the kit's rule (base darkened by 39 %, #5d1010) where the page had chosen #7F1D1D, and the dark chip text is #f69898 where it was #fca5a5. The nav bar's GitHub button gives way to the fork ribbon, pointing at go-pdfkit/pdfkit, the organisation's namesake library. mark-github.html is the kit's icons/github.html. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the landing on go-fleettools/landingkit v0.2.0, the way go-fileshare.github.io#24 did for the reference.
What changes
hugo.tomlimports the module;go.modpins v0.2.0;kit.go(//go:build tools) keeps Renovate'sgo mod tidyfrom deleting the requirement;actions/setup-goruns before Hugo indeploy-pages.yml.styles.html(the kit's sheet without the fork-ribbon rules),theme-toggle.html,icons/book.html,icons/mark-github.html.icons/link-external.htmlstays as the site's own Octicon, with itsOCTICONS-LICENSE.[params.brand]is generated bylandingkit brand static/img/logo.svgand replaces the hand-derived block: base#991b1b, bright#ef4444, deep#5d1010(was#7F1D1D), chipFg#5d1010(was#7F1D1D), chipFgDark#f69898(was#fca5a5), washDeeprgba(93,16,16,.06).darkreader-lockcomes from the kit'sstyles.html(merged into the old sheet by Tell the Dark Reader extension to stand aside (darkreader-lock) #23); it is emitted once..tag.ready, the cards, the terminal) is in the kit, so there is nosite-styles.html.Verification
landingkit verify go-pdfkit.github.io go-fileshare.github.io:setViewport), light and dark: no horizontal scroll on main or on the branch. The theme toggle is hit-tested and clicked and changesdata-theme. The ribbon is hit-tested and clickable at every width.Visual differences, section by section (main vs branch, screenshots)
deep#7F1D1D→#5d1010), seen in the headline accent and the primary button.chipFg, andchipFgDarkin dark mode) and the gradient on card details.Checks
No check changes:
deploy-pages(build) anddocs;docsis green on main again since go-pdfkit/.github#23.🤖 Generated with Claude Code