Repository navigation
README: toolkit does import mvvm's core, since v0.124.0 - #35
Merged
Merged
Conversation
The README said toolkit never imports mvvm. It has since v0.124.0 (PR #165, 2026-08-07): 107 of its files do, and widgets expose state as observables. What it must not import is a binder package, which would be a cycle. Measured with go list -deps. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said "
toolkit, in turn, never importsmvvm". Measured withgo list -deps:go-widgets/mvvmimports no go-widgets package: true, and kept;Label.Text()is an*mvvm.Observable[string];mvvm/tkbind; that would be the cycle.The paragraph now says that. README only.
🤖 Generated with Claude Code