chore!: master now targets PHP 8.5+ only - #218
Merged
Merged
Conversation
master becomes the line for PHP 8.5 development; the 8.4-compatible 4.x branch continues to receive fixes and cascades them forward via the new cascade-merge workflow. - composer.json: require php >=8.5 (was >=8.4), alias dev-master to 8.5-dev (was 4.x-dev) - README badge and CLAUDE.md requirement/CI notes updated to 8.5 - CI: drop the 8.4 leg from the PHPUnit matrix (8.5 lowest/highest + 8.6 experimental remain), move the PHPStan job and Copilot setup step from PHP 8.4 to 8.5 - .github/copilot-instructions.md: correct its already-stale PHP version facts (was still describing >=8.2 and an 8.2/8.3/8.4 matrix) to match the new 8.5 baseline Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013xfs2FHTpipY3LRBtC5vLK
master requires PHP >=8.5 as of this branch, so the >= 80500 check in resolveName() is always true and its fallback (pre-8.5 self/parent handling) is now dead code — caught by PHPStan level 10 on the CI job this same PR moved from PHP 8.4 to 8.5. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013xfs2FHTpipY3LRBtC5vLK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterbecomes the line for PHP 8.5 development going forward. The 8.4-compatible4.xbranch (released as 4.0.0) continues to receive fixes and cascades them forward intomastervia the cascade-merge workflow added in #216.require.phpbumped from>=8.4to>=8.5;extra.branch-alias.dev-masterchanged from4.x-devto8.5-dev, as requested.>=8.5.8.4leg from thephpunit.ymlmatrix (8.5lowest/highest +8.6experimental remain), moved thephpstan.ymljob and the Copilotcopilot-setup-steps.ymlPHP setup step from 8.4 to 8.5..github/copilot-instructions.md: this file was already out of sync with the repo (still said>=8.2and an8.2/8.3/8.4CI matrix even before this change) — updated its PHP-version facts to match the new 8.5 baseline while it was being touched.Left untouched: mentions of specific PHP versions that describe when a language feature was introduced rather than the library's minimum requirement — e.g. README's "PHP 8.4 property hooks" feature callout,
PHP_VERSION_ID-gated test logic, and the versioned test stub filenames (FileWithClasses82.phpetc.), since the AST parser continues to support reflecting code written for older PHP versions regardless of the host's minimum requirement.Test plan
vendor/bin/phpunit— 13,743 tests pass locally on PHP 8.5.9composer.jsonvalidated as well-formed JSON🤖 Generated with Claude Code
https://claude.ai/code/session_013xfs2FHTpipY3LRBtC5vLK
Generated by Claude Code