chore: bump cli-engine to 0.3.4 (non-interactive OAuth scope step-up)#73
Merged
Conversation
cli-engine 0.3.4 makes OAuth scope step-up fire for under-scoped tokens in non-interactive sessions (godaddy/cli-engine#34). Before this, a command run without a TTY (agent harness, piped stdio) that held a token missing a required scope hard-errored with "missing required scope(s)" instead of launching the OAuth flow, while the same command auto-authenticated once the token was cleared. With the bump, `gddy domain suggest` / `domain purchase` and any scoped command now step up to acquire the missing scope regardless of interactivity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
cli-enginefrom0.3.0→0.3.4(rust/Cargo.toml,rust/Cargo.lock).Why
cli-engine 0.3.4 (godaddy/cli-engine#34) fixes an asymmetry in OAuth scope step-up. Previously,
PkceAuthProvider::get_credential_forgated step-up on a TTY check only when a token already existed: a command run without a TTY (agent harness, piped stdio) that held a token missing a required scope hard-errored withmissing required scope(s): …; run auth login --env … --scope …, while the no-token path always launched the browser flow. The result — surfaced in a bug bash — was thatgddy domain suggestfailed on first run but auto-authenticated once the token was cleared, and the error's suggested fix (auth login --scope …) was the wrong path.With the bump, any scoped command (
domain suggest,domain purchase, …) now steps up to acquire the missing scope regardless of interactivity. The requested set staysdefaults ∪ granted ∪ required, so step-up never narrows an existing grant.Notes
clap_complete v4.6.5(cli-engine's shell-completion feature, added in 0.3.3).src/auth.rsdelegates straight toPkceAuthProvider, and domain commands already declare their scopes viawith_scopes.Verification
cargo build,cargo clippy --all-targets -- -D warnings, andcargo test(182 passed) all clean.🤖 Generated with Claude Code