Conversation
…at a bridge save uses the defaults
…ings, and name the scopes of the settings test
kmatasfp
added this pull request to stack #3950
September 26, 2026 05:58
… its companion files
kmatasfp
marked this pull request as ready for review
September 26, 2026 06:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves GOL-643
stacked on #3949
This change removes the filesystem snapshot benchmark from the executor. The benchmark measured rustic over the blob storage of Golem in golem-dev, and its results decided the values of the store. No later step runs it again, and it must not reach
main.What goes
filesystem_snapshot/benchmark/, with its golden file and its tests.fs-snapshot-benchmark: its[[bin]]entry, its rootsrc/fs_snapshot_benchmark.rs, the featurefs-snapshot-benchmarkand the re-export of itsmaininlib.rs.clapof the executor, optional and dev. Only the benchmark used it. The workspace still usesclapin other crates, so only the line of the executor goes fromCargo.lock.Repository::inspect, the freeinspect,InspectReportandrepository_settingsinrustic/mod.rs, with their three tests. Only the benchmark called them.Repository::with_settings, thesettingsfield ofRepository, and the repository settings parameter of the freesave. Only the benchmark set a value other than the default. A save of the bridge now makes a missing repository withRepositorySettings::DEFAULT, which is what the field held for every other caller.One test takes the place of the inspect tests. The removed test
a_repository_keeps_the_settings_of_its_first_save_and_inspect_gives_themwas the only check that the settings reach the config file of a new repository, that a repository that exists keeps its settings, and that fixed chunks and no compression change the stored data. The store depends on this path throughopen_or_create. The new testa_repository_keeps_the_settings_of_its_creation_and_a_bridge_save_uses_the_defaultschecks the same things. It reads the config file withopen_existing, so it needs noinspect.What stays, and why
rayonstays. The store uses it for the thread pool of a save or a prune.Repositoryand itsnew,save,save_with,restore,forgetandprunestay. The store does not call them, but the bridge tests use them to test the backend, the storage call deadline, the tree pack cache and the change detection, which the store uses.save_report,prune_reportandtimed, which the store calls, fill them. This change does not touch those functions.pub(super)items ofrustic/mod.rskeep their visibility. The benchmark was a sibling module, so they needed it. A narrower visibility would change many lines that Add the rustic filesystem snapshot store #3949 can still change, and it removes no code.This change also removes
golem_registry_service.db-wal, a SQLite journal that a generation of the OpenAPI spec left in the repository root, and makes.gitignoreignore the companion files ofgolem_registry_service.db. It is not part of the benchmark, but it must not reachmain.The other benches in
golem-worker-executor/benches/, the benchmarks ofgolem-test-frameworkandintegration-tests, and the filesystem workload benchmark ofsandbox_filesystemare not this benchmark, and they stay.A companion pull request in golem-cloud removes the snapshot benchmark parts of the workflow that built and ran this binary. It keeps the agent I/O measurement of that workflow.