Preserve exact-zero SFT self-conditioning - #775
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
sylvesterkaczmarek
marked this pull request as draft
August 15, 2026 17:29
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 18:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the self-conditioning semantics reported in #773.
Summary
Preserve an exact-zero self-conditioning embedding in the Hackable Diffusion SFT adapter when self-conditioning is disabled.
Why
The current adapter represents “no self-conditioning” using all-zero vocabulary logits and then passes them through
encode_logits. Becauseencode_logitsapplies a softmax and embedding projection, zero logits produce a vocabulary-mean embedding rather than an exact zero self-conditioning signal.The main DiffusionGemma sampler already initializes self-conditioning with an all-zero embedding tensor. This change makes the Hackable Diffusion SFT path consistent with that behavior without changing the meaning of actual previous-pass logits.
This intentionally addresses only the self-conditioning portion of #773; it does not change the separate multi-canvas cache/decode behavior discussed there.
Testing
pyink --checkpassed on all five changed files