Repository navigation
fix(patch): cherry-pick 62364cb to release/v0.61.0-preview.0-pr-29443 to patch version v0.61.0-preview.0 and create version 0.61.0-preview.1 - #29455
Conversation
|
📊 PR Size: size/XL
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for the latest GA models, gemini-3.5-flash-lite and gemini-3.8-flash, by updating the core configuration and routing logic. It refactors existing model-specific flags into more flexible 'latest' flags and ensures that backend requests are correctly mapped. Additionally, it updates various unit and integration tests to accommodate these changes and maintain robust fallback behavior. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: +9.76 kB (+0.03%) Total Size: 35.4 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the latest GA models, Gemini 3.8 Flash and Gemini 3.5 Flash Lite, by gating them behind experiment flags and updating model resolution, fallback strategies, and configuration schemas. The review feedback highlights two critical issues: first, a correctness bug in contentGenerator.ts where passing gcConfig instead of the full config to getBackendModelMappings disables dynamic mapping to the latest models; second, an architectural risk in models.ts where mutating module-level global variables for active defaults can cause race conditions and state leakage across concurrent sessions.
Note: Security Review did not run due to the size of the PR.
0e6fa77
into
release/v0.61.0-preview.0-pr-29443
This PR automatically cherry-picks commit 62364cb to patch version v0.61.0-preview.0 in the preview release to create version 0.61.0-preview.1.