Repository navigation
fix: resolve dynamic api url to support non-localhost environments - #223
Open
Benny45123 wants to merge 1 commit into
Open
Benny45123 wants to merge 1 commit into
Benny45123 wants to merge 1 commit into
Conversation
- Dynamically resolve apiUrl to window.location.origin in production - Support custom VITE_API_URL environment variable - Update Dockerfile with ARG/ENV for VITE_API_URL - Update README documentation and add frontend/.env.example Fixes google-gemini#144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #144
Problem
In
frontend/src/App.tsx, the production build used a hardcoded API URL:http://localhost:8123
When deployed in Docker, on a remote server, or accessed over a local network, the browser treated
localhostas the client machine. This caused API requests such as/threadsto fail withnet::ERR_CONNECTION_REFUSED.Solution
window.location.originas the default API URL in production.VITE_API_URLsupport for deployments where the backend is hosted separately.ImportMetaEnvinfrontend/src/vite-env.d.tsfor TypeScript type safety.VITE_API_URLbuild-argument support toDockerfile.frontend/.env.exampleand update the README with configuration instructions.Verification
window.location.origin.http://localhost:2024.VITE_API_URLtakes precedence when provided.localhost.