Fix file already exist error while running substitute in Docker - #2885
Merged
Conversation
k311093
force-pushed
the
subst
branch
2 times, most recently
from
July 29, 2026 04:22
45c7d89 to
f2f06f2
Compare
k311093
marked this pull request as ready for review
July 29, 2026 06:07
Databean
approved these changes
Jul 29, 2026
In the OverlayFS, even if unlink() is succeeded, looks like there is a delay between unlink call and the file is actually disappears. Change to use rename call which ensures atomic operation for substitution.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the OverlayFS, even if unlink() is succeeded, looks like there is a delay between unlink call and the file is actually disappears.
Change to use rename call which ensures atomic operation for substitution.