Skip to content

ci: don't clear HTML redirects when building translations - #3241

Open
rmyndharis wants to merge 1 commit into
google:mainfrom
rmyndharis:fix/translation-redirects
Open

ci: don't clear HTML redirects when building translations#3241
rmyndharis wants to merge 1 commit into
google:mainfrom
rmyndharis:fix/translation-redirects

Conversation

@rmyndharis

Copy link
Copy Markdown

Building a translation exported MDBOOK_OUTPUT__HTML__REDIRECT='{}', which
wiped the redirect table and made renamed or removed pages 404 in every
non-English book. Clearing the redirects is no longer needed because
book.toml is restored for each translation, so mdbook now emits the same
redirect pages as the English build.

Closes #2022.

Building a translation exported MDBOOK_OUTPUT__HTML__REDIRECT='{}', which
wiped the redirect table and made renamed or removed pages 404 in every
non-English book. Clearing the redirects is no longer needed because
book.toml is restored for each translation, so mdbook now emits the same
redirect pages as the English build.

Closes google#2022.

@qwandor qwandor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but @mgeisler knows this better.

@djmitche
djmitche removed their request for review August 1, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 page breaks translations

2 participants