[Code health] Don't allow saving a duplicate vertex during polygon drawing session#3750
Closed
shobhitagarwal1612 wants to merge 9 commits into
Closed
[Code health] Don't allow saving a duplicate vertex during polygon drawing session#3750shobhitagarwal1612 wants to merge 9 commits into
shobhitagarwal1612 wants to merge 9 commits into
Conversation
shobhitagarwal1612
requested review from
andreia-ferreira
and removed request for
hassan-nsubuga
May 20, 2026 18:28
shobhitagarwal1612
had a problem deploying
to
e2e-approval
May 20, 2026 18:28 — with
GitHub Actions
Failure
shobhitagarwal1612
had a problem deploying
to
e2e-approval
May 20, 2026 18:28 — with
GitHub Actions
Failure
shobhitagarwal1612
had a problem deploying
to
e2e-approval
May 20, 2026 18:31 — with
GitHub Actions
Failure
shobhitagarwal1612
temporarily deployed
to
e2e-approval
May 20, 2026 18:34 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3750 +/- ##
============================================
+ Coverage 68.06% 68.09% +0.02%
- Complexity 1618 1619 +1
============================================
Files 369 369
Lines 9542 9554 +12
Branches 1246 1248 +2
============================================
+ Hits 6495 6506 +11
Misses 2377 2377
- Partials 670 671 +1
🚀 New features to boost your workflow:
|
shobhitagarwal1612
had a problem deploying
to
e2e-approval
May 21, 2026 14:37 — with
GitHub Actions
Failure
shobhitagarwal1612
temporarily deployed
to
e2e-approval
June 7, 2026 07:15 — with
GitHub Actions
Inactive
shobhitagarwal1612
temporarily deployed
to
e2e-approval
June 7, 2026 07:36 — with
GitHub Actions
Inactive
andreia-ferreira
left a comment
Collaborator
There was a problem hiding this comment.
Tested and works well 👍 Just a UI/UX question, the first vertex doesn't display a circle on it anymore, only after moving the map, is it intended?
Screen_recording_20260608_153052.webm
Member
Author
|
Let me take another pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3679
Separate committed and tentative vertices in
PolygonDrawingSession. This allows the persistence layer to safely store only the committed vertices without having to assume that the last vertex is user committed vertex or not.Changes verified using unit tests and testing the flow on a physical device.
@andreia-ferreira PTAL?