Skip to content
This repository was archived by the owner on Oct 11, 2024. It is now read-only.
This repository was archived by the owner on Oct 11, 2024. It is now read-only.

Don't rely on protobuf field serialization order #1357

Description

@jtoohill

Per the protobuf encoding guide, "Serialization order is an implementation detail and the details of any particular implementation may change in the future".

We rely on signatures over serialized protobufs in the google.keytransparency.v1.SignedEntry proto. There's probably other places as well, that's just the first one that come to mind. It happens to work because the protobuf implementation we use has a stable serialization order, but that shouldn't be relied on.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions