Repository navigation
Add Downlink TDoA configuration and session support - #143
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements support for Downlink Time Difference of Arrival (DL-TDoA) ranging, including the necessary UCI packet definitions, configuration parsing, session state management, and integration tests. Feedback focuses on improving the robustness of the configuration parsing in Rust by masking reserved bits when extracting the timestamp length, and leveraging PDL features to define structured arrays for anchor ranging rounds instead of manually chunking raw payloads.
sameer
force-pushed
the
dl-tdoa-config
branch
6 times, most recently
from
October 24, 2026 17:10
815c118 to
543d6c4
Compare
Pica did not support Downlink TDoA (DL-TDoA) session setup, preventing devices from configuring DL-TDoA sessions or active ranging rounds. This change adds the packet definitions, configuration parameters, and session validation needed to configure DL-TDoA sessions, along with tests for parameter validation.
sameer
force-pushed
the
dl-tdoa-config
branch
from
October 25, 2026 19:38
543d6c4 to
901453c
Compare
schilit
approved these changes
Oct 26, 2026
schilit
approved these changes
Oct 26, 2026
sameer
added a commit
that referenced
this pull request
Oct 27, 2026
#143 added Downlink TDoA packet definitions, session configuration, and round update commands, but Pica does not yet simulate DL-TDoA ranging rounds or send measurement notifications during active sessions. This CL: - Advertises Downlink TDoA support in device capability TLVs. - Validates active tag and anchor ranging rounds before session start. - Simulates Poll, Response, and Final DTM exchanges across anchors. - Emits DL-TDoA session info notifications to tags.
sameer
added a commit
that referenced
this pull request
Oct 29, 2026
#143 added Downlink TDoA packet definitions, session configuration, and round update commands, but Pica does not yet simulate DL-TDoA ranging rounds or send measurement notifications during active sessions. This CL: - Advertises Downlink TDoA support in device capability TLVs. - Validates active tag and anchor ranging rounds before session start. - Simulates Poll, Response, and Final DTM exchanges across anchors. - Emits DL-TDoA session info notifications to tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork for Dl-TDoA support in Pica by accepting and validating configs. #144 does the actual implementation.