Repository navigation
Support block stride and ranging intervals in two-way ranging - #151
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements support for block stride length in Two-Way Ranging (TWR) sessions. It introduces a default block stride length configuration, refactors block stride calculation to handle both DL-TDoA and TWR controller roles, and updates session configuration handling to dynamically adjust the next ranging deadline when the ranging interval changes. Additionally, the current ranging interval is now correctly populated in session info notifications, and comprehensive integration tests have been added to verify these behaviors. As there are no review comments, no further feedback is provided.
schilit
approved these changes
Oct 29, 2026
While PR #144 introduced block stride handling and notification intervals for DL-TDoA, Two-Way Ranging ignored BLOCK_STRIDE_LENGTH (0x2D) and still hardcoded current_ranging_interval to 0 in TWR SessionInfoNtf. Unify AppConfig::block_stride across DL-TDoA tags and TWR Controllers, reschedule next_ranging_at on active Session::set_app_config updates, and populate current_ranging_interval in TWR notifications. Closes #149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While PR #144 introduced block stride handling and notification intervals for DL-TDoA, Two-Way Ranging ignored BLOCK_STRIDE_LENGTH (0x2D) and still hardcoded current_ranging_interval to 0 in TWR SessionInfoNtf.
Unify AppConfig::block_stride across DL-TDoA tags and TWR Controllers, reschedule next_ranging_at on active Session::set_app_config updates, and populate current_ranging_interval in TWR notifications.
Closes #149