Repository navigation
Respect AOA_RESULT_REQ and normalize SESSION_INFO_NTF_CONFIG - #152
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements support for the AoaResultReq configuration in ranging sessions. It introduces the encode_aoa helper to conditionally encode azimuth and elevation based on the requested AoA type (Disabled, Enabled, Azimuth Only, or Elevation Only). It also updates the bounds checking and session notification configurations to respect the effective notification configuration when AoA is disabled. Additionally, integration tests have been added to verify these behaviors. I have no feedback to provide.
sameer
force-pushed
the
aoa-result-req
branch
from
October 28, 2026 22:31
935a4c8 to
b58e775
Compare
schilit
approved these changes
Oct 29, 2026
sameer
force-pushed
the
aoa-result-req
branch
from
October 29, 2026 01:33
b58e775 to
b46c3c6
Compare
While PR #144 added DL-TDoA measurement generation alongside Two-Way Ranging, Pica populated local azimuth and elevation AoA fields across TWR and DL-TDoA measurements even when disabled by AOA_RESULT_REQ. Pica also evaluated AoA notification bounds on disabled axes and ignored FiRa Note 2 notification filtering rules under disabled AoA. Zero disabled local AoA angles and figures of merit while preserving aoa_destination_* fields. Normalize SESSION_INFO_NTF_CONFIG via effective_session_info_ntf_config() according to FiRa Table 28 / Table 38 Note 2, and restrict AOA_BOUND_CONFIG filtering to enabled AoA axes. Closes #147
sameer
force-pushed
the
aoa-result-req
branch
from
October 29, 2026 01:35
b46c3c6 to
0b0b7aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While PR #144 added DL-TDoA measurement generation alongside Two-Way Ranging, Pica populated local azimuth and elevation AoA fields across TWR and DL-TDoA measurements even when disabled by AOA_RESULT_REQ. Pica also evaluated AoA notification bounds on disabled axes and ignored FiRa Note 2 notification filtering rules under disabled AoA.
Zero disabled local AoA angles and figures of merit while preserving aoa_destination_* fields. Normalize SESSION_INFO_NTF_CONFIG via effective_session_info_ntf_config() according to FiRa Table 28 / Table 38 Note 2, and restrict AOA_BOUND_CONFIG filtering to enabled AoA axes.
Closes #147